Skip to content

ARROW-9803: [Go] Add initial support for s390x#8011

Closed
vivkong wants to merge 1 commit into
apache:masterfrom
linux-on-ibm-z:master-s390x
Closed

ARROW-9803: [Go] Add initial support for s390x#8011
vivkong wants to merge 1 commit into
apache:masterfrom
linux-on-ibm-z:master-s390x

Conversation

@vivkong

@vivkong vivkong commented Aug 19, 2020

Copy link
Copy Markdown
Contributor

The initial support will allow the unit tests to pass on s390x.

@github-actions

Copy link
Copy Markdown

@kou

kou commented Aug 19, 2020

Copy link
Copy Markdown
Member

How about adding a CI job for s390x + Go on Travis CI as the first step like #7938 ?

Comment thread go/arrow/type_traits_decimal128.go Outdated
@pitrou

pitrou commented Aug 20, 2020

Copy link
Copy Markdown
Member

cc @kiszk

Comment thread go/arrow/type_traits_decimal128.go Outdated
@vivkong

vivkong commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

How about adding a CI job for s390x + Go on Travis CI as the first step like #7938 ?

I can definitely look into adding that. Will contact @kiszk.

kou pushed a commit that referenced this pull request Aug 26, 2020
As suggested by @kou in #8011, this will add a Travis CI job for Go on s390x.

Closes #8047 from vivkong/master-travis-s390x

Authored-by: Vivian Kong <vivkong@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@vivkong vivkong force-pushed the master-s390x branch 3 times, most recently from daa2981 to 3dd764b Compare September 16, 2020 19:10
The initial support will allow the unit tests to pass on s390x.
@vivkong

vivkong commented Nov 11, 2020

Copy link
Copy Markdown
Contributor Author

Hello @emkornfield, wondering if this can be considered for merging? I've updated the PR to use a constant to check for endianess. Thanks.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in aca7070 Nov 11, 2020
alamb pushed a commit to apache/arrow-rs that referenced this pull request Apr 20, 2021
As suggested by @kou in apache/arrow#8011, this will add a Travis CI job for Go on s390x.

Closes #8047 from vivkong/master-travis-s390x

Authored-by: Vivian Kong <vivkong@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou pushed a commit to apache/arrow-go that referenced this pull request Aug 30, 2024
As suggested by @kou in apache/arrow#8011, this will add a Travis CI job for Go on s390x.

Closes #8047 from vivkong/master-travis-s390x

Authored-by: Vivian Kong <vivkong@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants